Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include commas in the profile size, handle failure case of profile more than 500kB in size #5241

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix: include commas in the profile size, handle failure case of profile more than 500kB in size #5241

wants to merge 8 commits into from
+23 −5

Conversation

yashasvibajpai
Copy link
Contributor

@yashasvibajpai yashasvibajpai commented Oct 28, 2024 •
edited
Loading

Description

On debugging for the issue, we came across the two pointers addressed here.

  1. commas in JSON were unaccounted for in the final size of payload.
  2. we will throw an error in case a single profile's size itself crosses the 500 kb threshold set by Klaviyo themselves. Reference

Linear Ticket

Related to INT-2820, INT-2840

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@yashasvibajpai yashasvibajpai self-assigned this Oct 28, 2024
@yashasvibajpai yashasvibajpai requested review from koladilip and ItsSudip and removed request for koladilip October 28, 2024 11:27
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 73.25%. Comparing base (18c102f) to head (349310f).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...tionmanager/klaviyobulkupload/klaviyobulkupload.go 0.00% 17 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5241      +/-   ##
==========================================
+ Coverage   73.24%   73.25%   +0.01%     
==========================================
  Files         424      424              
  Lines       59960    59978      +18     
==========================================
+ Hits        43918    43938      +20     
+ Misses      13585    13579       -6     
- Partials     2457     2461       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashasvibajpai yashasvibajpai changed the title fix: include commas in the profile size, handle failure case of profile more than 5mb in size fix: include commas in the profile size, handle failure case of profile more than 500kB in size Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koladilip koladilip koladilip approved these changes

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

At least 2 approving reviews are required to merge this pull request.

Assignees

@yashasvibajpai yashasvibajpai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashasvibajpai @koladilip